Skip to content

Conversation

olia110
Copy link
Contributor

@olia110 olia110 commented Aug 25, 2025

This Pull request:

An optimized code path has been added for the common case where the Softmax axis is the last dimension (axis == size - 1).

@olia110 olia110 requested a review from lmoneta as a code owner August 25, 2025 15:53
@sanjibansg sanjibansg self-assigned this Aug 25, 2025
Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR,
Just some corrections for the case the shapes are not fully specified as integer values, but parametrised (dynamic)

@olia110 olia110 force-pushed the feature/contiguous-memory-fast-path branch from c51c2d9 to 5960569 Compare August 26, 2025 15:47
Copy link
Contributor

@sanjibansg sanjibansg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!

Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a couple of small comments.
Thank you for this improvement!

Copy link

github-actions bot commented Sep 3, 2025

Test Results

    21 files      21 suites   3d 20h 55m 5s ⏱️
 3 644 tests  3 492 ✅  0 💤 152 ❌
74 777 runs  74 607 ✅ 18 💤 152 ❌

For more details on these failures, see this check.

Results for commit 1848c97.

@lmoneta lmoneta merged commit 4d743c7 into root-project:master Sep 3, 2025
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants